Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

version >=1.1.0 has broken in node 8 #145

Closed
zoobestik opened this issue Nov 22, 2020 · 2 comments
Closed

version >=1.1.0 has broken in node 8 #145

zoobestik opened this issue Nov 22, 2020 · 2 comments
Labels
bug

Comments

@zoobestik
Copy link

zoobestik commented Nov 22, 2020 •
edited

It happened after refactor mix - lib/syntax/config/mix.js#L23
But it's "node": ">=8.0.0"
Example log with usage in csso-webpack-plugin
@zoobestik zoobestik changed the title Version 1.1.0 has broken Node 8 v1.1.0 broke node 8 Nov 22, 2020
@zoobestik zoobestik changed the title v1.1.0 broke node 8 version >=1.1.0 has broken in node 8 Nov 22, 2020
@lahmatiy
Copy link
Member

That's interesting, spread operator in object literals was added in 8.3 (according to MDN).
Not sure we need to fix it. But I'll rollback it for 1.x

@lahmatiy lahmatiy added the bug label Nov 26, 2020
lahmatiy added a commit that referenced this issue Nov 26, 2020
@lahmatiy
Roll back to use spread syntax since it not supported by nodejs < 8.3 (…
053149c 
…fixes #145)
@lahmatiy
Copy link
Member

Fixed in 1.1.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@zoobestik @lahmatiy