Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Uptime distribution #28

Merged
merged 15 commits into from
Mar 7, 2024
Merged

Uptime distribution #28

merged 15 commits into from
Mar 7, 2024

Conversation

kaylendog
Copy link
Contributor

No description provided.

kaylendog
kaylendog commented Mar 2, 2024
View reviewed changes
Copy link
Contributor Author

@kaylendog kaylendog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some things to think about.

crates/comm/src/peer/mod.rs Outdated Show resolved Hide resolved
crates/protocol/proto/str/packet/v1/packet.proto Outdated Show resolved Hide resolved
crates/comm/src/peer/mod.rs Outdated Show resolved Hide resolved
crates/comm/src/peer/outbound.rs Outdated Show resolved Hide resolved
@Heidar-An
Copy link
Contributor

think most of it is done? going to move the time function to Socket now.

@Heidar-An Heidar-An marked this pull request as ready for review March 3, 2024 19:39
@kaylendog
Copy link
Contributor Author

Did you ever get this tested?

@Heidar-An
Copy link
Contributor

Heidar-An commented Mar 6, 2024 •
edited

I tested it on my machine but I'm not confident about it so I would make it be the final branch to be merged.

kaylendog
kaylendog commented Mar 7, 2024
View reviewed changes
crates/comm/src/peer/inbound.rs Outdated Show resolved Hide resolved
crates/comm/src/peer/mod.rs Outdated Show resolved Hide resolved
crates/comm/src/peer/inbound.rs Outdated Show resolved Hide resolved
crates/comm/src/peer/mod.rs Outdated Show resolved Hide resolved
crates/comm/src/peer/outbound.rs Outdated Show resolved Hide resolved
crates/comm/src/socket/mod.rs Outdated Show resolved Hide resolved
crates/comm/src/socket/packet.rs Outdated Show resolved Hide resolved
@kaylendog
Copy link
Contributor Author

Merge main into this branch when possible.

@kaylendog kaylendog merged commit 9806c7a into main Mar 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Heidar-An Heidar-An Heidar-An left review comments

Assignees

@Heidar-An Heidar-An

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@kaylendog @Heidar-An