Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code blocks are not contained #263

Closed
JacksonChen666 opened this issue Apr 12, 2023 · 4 comments · Fixed by #265
Closed

Code blocks are not contained #263

JacksonChen666 opened this issue Apr 12, 2023 · 4 comments · Fixed by #265

Comments

@JacksonChen666
Copy link
Contributor

JacksonChen666 commented Apr 12, 2023

Describe the bug
Code blocks, when very long, are allowed to overflow outside of the contain class.

Reproduction steps
Steps to reproduce the behavior:

  1. Create a code block with a really really long line, so long that the text is larger than the container (maybe copy this line?)
  2. Look at code block

Expected behavior
The code block does not overflow outside of the box

Screenshots
A cState status page. The code block goes outside of where the usual content is.
A cState status page. The code block is not overflowing, and is scrolled a little bit.

Desktop (please complete the following information):

  • OS: macOS
  • Browser LibreWolf (Firefox fork)
  • Version 111.0.1-1

Additional context
The solution was included in the picture, and also below:

pre {
    overflow-x: scroll;
}

Make sure to test it a variety of cases. (I also might make a PR myself to fix this issue since you know, I already got the solution right above)

@mistermantas
Copy link
Member

Make sure to test it a variety of cases. (I also might make a PR myself to fix this issue since you know, I already got the solution right above)

Thanks for creating an issue. Yes, you have the right solution. Well, sort of, this should be limited to the container box for Markdown text, like .markdown pre or something else. But pre is not used anywhere else by default.

If you have the time, feel free to make a PR to merge it into dev (not sure if the branch exists still, but it should).

@mistermantas
Copy link
Member

I 7

@JacksonChen666
Copy link
Contributor Author

I 7

?

@mistermantas
Copy link
Member

mistermantas commented Aug 28, 2023

I 7

?

that’s strange, I must have accidentally replied. This will be in the newest cstate update soon, possibly later in October, just cleaning up the issues before I release it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants