Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix pycsdiff build when more Python versions are used #67

Merged
merged 3 commits into from
Aug 1, 2022

Conversation

lzaoral
Copy link
Member

@lzaoral lzaoral commented Aug 1, 2022

No description provided.

@lzaoral lzaoral added the bug label Aug 1, 2022
@lzaoral lzaoral requested a review from kdudka August 1, 2022 13:19
@lzaoral lzaoral self-assigned this Aug 1, 2022
@lzaoral lzaoral marked this pull request as ready for review August 1, 2022 13:19
Copy link
Member

@kdudka kdudka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good but I would reword the commit messages to talk about Python modules rather than Python plugins.

.. so that it is more clear that it is the same version of the pycsdiff module
but for different Python versions.
They were built in the same directory with the same name, so they were
overwriting each other.
It is incompatible with sanitizers at the moment.
@lzaoral lzaoral merged commit 8852b66 into csutils:main Aug 1, 2022
@lzaoral lzaoral deleted the fix-epel7-pycsdiff3 branch August 1, 2022 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants