results: reset imp flag in the list of important findings only #138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kdudka
added a commit
to kdudka/csmock
that referenced
this pull request
Nov 9, 2023
Tagging important findings does not make sense in the list of important findings only. Resolves: https://issues.redhat.com/browse/OSH-343 Closes: csutils#138
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
py/common/results.py
Outdated
| @@ -313,7 +313,7 @@ | |||
| % (js_file, chk_re, csgrep_args) | |||
|
|
|||
| # finally take all defects that were tagged important by the scanner already | |||
| cmd += f" | csgrep --mode=json <(csgrep --mode=json --imp-level=1 '{js_file}') -" | |||
| cmd += f" | csgrep --mode=json --set-imp-level=0 <(csgrep --mode=json --imp-level=1 '{js_file}') -" | |||
Check warning
Code scanning / vcs-diff-lint
Line too long (107/100)
kdudka
added a commit
to kdudka/csmock
that referenced
this pull request
Nov 9, 2023
Tagging important findings does not make sense in the list of important findings only. Resolves: https://issues.redhat.com/browse/OSH-343 Closes: csutils#138
|
@hanchuntao Thanks for review! |
Tagging important findings does not make sense in the list of important findings only. Resolves: https://issues.redhat.com/browse/OSH-343 Closes: csutils#138
kdudka
force-pushed
the
set-imp-level
branch
from
f15bfff
to
53157f1
Compare
jperezdealgaba
pushed a commit
to jperezdealgaba/csmock
that referenced
this pull request
Nov 22, 2023
Tagging important findings does not make sense in the list of important findings only. Resolves: https://issues.redhat.com/browse/OSH-343 Closes: csutils#138
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tagging important findings does not make sense in the list of important findings only.
Resolves: https://issues.redhat.com/browse/OSH-343
Depends-on: csutils/csdiff#149