Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Design error handling mechanism in case Uref cannot be solved #118

Closed
2 tasks
Tracked by #116
csyhuang opened this issue Jun 26, 2024 · 1 comment
Closed
2 tasks
Tracked by #116

Design error handling mechanism in case Uref cannot be solved #118

csyhuang opened this issue Jun 26, 2024 · 1 comment
Assignees
Labels
help wanted MDTF Preparation work to deploy the package onto anaconda and integrate it into MDTF

Comments

@csyhuang
Copy link
Owner

csyhuang commented Jun 26, 2024

So far when working with model/reanalysis data, there are two scenarios in which Uref cannot be solved, which would raise an error when calling QGField.compute_reference_states and the user cannot proceed to calculate LWA:

(1) The input field is unphysical/unrealistic or vertical resolution is too low that cannot capture the stratosphere structure
(2) The input field is realistic but latitudinal/vertical resolution is too high

In case (1), it is legitimate to throw an error since the input is problematic. However, in case (2), user shall be able to proceed to computation of LWA - even though Uref is not numerically solvable, LWA (but not the fluxes) can still be computed since computation only requires Qref.

This task would involve two components:

def compute_lwa_only(self):
    """
    This returns layer-wise LWA(height, lat, lon) and FAWA(height, lat)
    """
@csyhuang csyhuang added help wanted MDTF Preparation work to deploy the package onto anaconda and integrate it into MDTF release1.3 labels Jun 26, 2024
@csyhuang csyhuang self-assigned this Jul 10, 2024
@csyhuang
Copy link
Owner Author

csyhuang commented Jul 11, 2024

This is tackled by b45c405 :
After calling QGField.compute_reference_state, if Uref cannot be solved, QGField.nonconvergent_uref will be set to True, which will be checked in the MDTF procedures.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted MDTF Preparation work to deploy the package onto anaconda and integrate it into MDTF
Projects
Status: No status
Development

No branches or pull requests

1 participant