Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix screen command logging option #29

Merged
merged 3 commits into from
Jan 28, 2019
Merged

fix screen command logging option #29

merged 3 commits into from
Jan 28, 2019

Conversation

behrisch
Copy link
Contributor

fixes raspbian compatibility

@sylvandb
Copy link

sylvandb commented Jan 27, 2019

The problem is multiple versions of screen and this fix may not be sufficient.

Try screen --version to see the version of screen you have and man screen to see if your version supports -Logfile or if it supports a filename following the -L option. You can also try: screen --help | grep -- -L

The versions I have (not a complete list!):

4.02 does not support a filename following -L, and this fix causes screen to attempt to execute the log filename instead of the next command: -L Turn on output logging.

4.05 does support -L filename -- probably the version this pull request was developed: -L [file] Turn on output logging. Set logfile name.

4.06 does support the -Logfile filename option: -L Turn on output logging. -Logfile file Set logfile name.

@behrisch
Copy link
Contributor Author

Even if it not solves everything, it is better than before, especially since the c't article mentions raspbian as supported.

@behrisch
Copy link
Contributor Author

According to the change log the option was added in 4.5.0 so I tried to fix the script according to that but I could not test it.

@drushbrook
Copy link
Contributor

Apart from losing the named session capability - what else would we lose if we dropped screen and used nohup and backgrounded processes?

Given none of the things that run in the screen session require input we still can monitor the processes by redirecting stdout / stderr to a file?

@behrisch
Copy link
Contributor Author

@drushbrook I would very much prefer not to use screen but I suppose there was a reason to do it that way (which I do not know).

@merlinschumacher
Copy link
Contributor

I plan to move the entire process to a single python script in the near future, thus rendering the screen issue moot.

@behrisch behrisch deleted the screen_log branch January 28, 2019 13:24
@kueblc
Copy link
Collaborator

kueblc commented Jan 28, 2019

I plan to move the entire process to a single python script in the near future, thus rendering the screen issue moot.

If you do this, please keep entry points for each process. These scripts may be independently useful in doing things other than flashing! 😄

@sylvandb
Copy link

It would be nice in a single python script, if it were import'able and (at least) the former separate scripts were separately callable functions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants