Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"All unsaved changes will be lost" does not appear when closing #302

Closed
QuickBanjo opened this issue Nov 7, 2021 · 1 comment
Closed
Labels
type:bug Something isn't working
Milestone

Comments

@QuickBanjo
Copy link
Contributor

Describe the bug

When taking various actions in the IDE that would discard outstanding changes, such as opening another project, a confirmation modal appears, saying something along the lines of "All unsaved changes will be lost". The modal would have options to continue the action or cancel.

When closing the IDE via the OS, this modal does NOT appear.

To Reproduce

On version 1.7.0,

  1. Open Ct.js.
  2. Open any project with at least one non-texture asset.
  3. Open the non-texture asset in its respective editor.
  4. Make a change.
  5. Click "Apply" or "Done", without saving.
  6. Close the Ct.js window via your OS, e.g. click on the big 'X' in the upper-right/upper-left corner, as you would any other app.
  7. Actual behavior: When the IDE is closed, nothing else happens.

This appears to be occurring on both Windows and Linux.

Expected behavior

When the IDE is closed with unsaved changes, the described confirmation modal appears.

System information report

Ct.js v1.7.0 😽 (packaged)

NW.JS v0.51.2
Chromium v88.0.4324.182
Node.js v15.8.0
Pixi.js v5.1.2

WebGL available
WebGL vendor AMD
[redacted]
OS linux x64 [redacted]

Screenshots

Expected warning when closing the IDE. This example occurs when clicking "Open Project".
close-ide-expected

Example project

n/a. Should occur with any project with unsaved changes.

@QuickBanjo QuickBanjo added the type:bug Something isn't working label Nov 7, 2021
@CosmoMyzrailGorynych CosmoMyzrailGorynych added this to To do (max priority) in Main dev board Dec 12, 2021
@CosmoMyzrailGorynych CosmoMyzrailGorynych added this to the v2.0 milestone Dec 12, 2021
CosmoMyzrailGorynych added a commit that referenced this issue Dec 12, 2021
…ialogue now also appears when you close the app with unsaved changes

Closes #302
@CosmoMyzrailGorynych
Copy link
Collaborator

Closed in 5f2c4a4.
Also fixes the situation where ct.js asks for your confirmation to close even if you've just opened a project.

Main dev board automation moved this from To do (max priority) to Done Dec 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:bug Something isn't working
Projects
Archived in project
v2/v3
  
v2
Development

No branches or pull requests

2 participants