Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

⚡ Lossless Image Optimization #374

Merged
merged 1 commit into from Oct 2, 2022

Conversation

FlipFloop
Copy link
Contributor

@FlipFloop FlipFloop commented Sep 30, 2022

While I figure out how to contribute on M1.
ImageOptim was the app used.

Before sending the pull request, make sure that:

  • gulp build runs without issues.
  • if you develop a catmod, a test project and docs are also present. Put a test project into a catmod's directory.
  • if it is a work-in-progress, explicitly mark it as such in the title with the WIP: prefix.
  • The title of the pull request has a suitable emoji from the Comigoji guide. The title will look broken on GitHub, but it streamlines further merging and makes writing a pretty changelog easier.

Closes #(issue's index).

Changes proposed in this pull request:

  • Use ImageOptim to perform lossless optimization on all images.

Help wanted: (optional, e.g. a request for GUI revamp)

  • Build this as I have an M1 chip.

Ping @CosmoMyzrailGorynych

While I figure out how to contribute on M1.
ImageOptim was the app used.
Copy link
Contributor

@markmehere markmehere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works! 🎉 Seems like a good idea. Haven't compiled to see exactly how much this shaves off the builds but I'm happy with it.

@FlipFloop
Copy link
Contributor Author

@markmehere Probably very little. I think it saved some 10mb lmao.

@CosmoMyzrailGorynych
Copy link
Collaborator

How come I approved it twice

@CosmoMyzrailGorynych
Copy link
Collaborator

Maybe we will need a build task for this in the future

@CosmoMyzrailGorynych CosmoMyzrailGorynych merged commit 468ff3b into ct-js:develop Oct 2, 2022
@FlipFloop
Copy link
Contributor Author

@CosmoMyzrailGorynych What do you mean? Also I think Github actions can do what this PR did on build.

@CosmoMyzrailGorynych
Copy link
Collaborator

That's exactly what I mean.
We use Gitlab CI instead of Github actions.

@FlipFloop
Copy link
Contributor Author

So @CosmoMyzrailGorynych are you asking me to integrate image processing in the repo through GitLab CI? Also, how come that runs there and not here.
More on this, do we perform minification of Game Assets (Image processing/optimization) when building/exporting a game?

@CosmoMyzrailGorynych
Copy link
Collaborator

are you asking me to integrate image processing in the repo through GitLab CI?

It would be great, but I was just thinking out loud before.
For ct.js builds, we have Gitlab CI. Period. GH actions can be added for PRs, regular commits and such, but ct.js' build pipeline stays where it is now.

More on this, do we perform minification of Game Assets (Image processing/optimization) when building/exporting a game?

No, ct.js currently doesn't do it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants