New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
⚡ Lossless Image Optimization #374
Conversation
While I figure out how to contribute on M1. ImageOptim was the app used.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works! 🎉 Seems like a good idea. Haven't compiled to see exactly how much this shaves off the builds but I'm happy with it.
@markmehere Probably very little. I think it saved some 10mb lmao. |
How come I approved it twice |
Maybe we will need a build task for this in the future |
@CosmoMyzrailGorynych What do you mean? Also I think Github actions can do what this PR did on build. |
That's exactly what I mean. |
So @CosmoMyzrailGorynych are you asking me to integrate image processing in the repo through GitLab CI? Also, how come that runs there and not here. |
It would be great, but I was just thinking out loud before.
No, ct.js currently doesn't do it. |
While I figure out how to contribute on M1.
ImageOptim was the app used.
Before sending the pull request, make sure that:
gulp build
runs without issues.WIP:
prefix.Closes #(issue's index).
Changes proposed in this pull request:
Help wanted: (optional, e.g. a request for GUI revamp)
Ping @CosmoMyzrailGorynych