New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Coordinates notebook corrected. #54
Conversation
I proposed some minor updates here: |
Some minor fixes
Thanks max for the review ;) |
I think this belongs to ctapipe, you should also put it there |
Ok I'll do it. |
I would try to avoid duplicities, so if this is going to go to ctapipe maybe you can completely move it there? |
I agree...I can remove it from here as long as the PR in ctapipe is merged. |
Sorry, I could not follow all the changes from last week... any progress on this point? |
I guess that i can remove the notebook since last week there has been a major coordinates refactoring. We can really remove it from here and there will just be the updated one in the ctapipe folder. let me do this and then you can merge the PR. |
ok you can merge the PR @rlopezcoto. |
Coordinate usage corrected after discussion with @maxnoe on the implementation of the coordinates with astropy. One should first create a frame and then create points in this frame with SkyCoord from astropy.
Related to cta-observatory/ctapipe#842
@maxnoe could you check this notebook? I'm doing the transformation from camera to AltAz explicitely for each frame.