Add test how it should be #842
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Just to add a comment: this PR goes in the way of having the coordinate frames behaving correctly (and being used correctly, see #727) with the astropy SkyCoord class.
Both approaches needs to be consistent across the whole ctapipe (which is not the case right now). Tests, notebooks and classes using coordinates have to be updated accordingly. PLAN: The plan might be to make a small fix now and use astropy and then compare it with @ParsonsRD implementation. |
Codecov Report
@@ Coverage Diff @@
## master #842 +/- ##
==========================================
+ Coverage 73.52% 73.54% +0.01%
==========================================
Files 211 211
Lines 12066 12075 +9
==========================================
+ Hits 8871 8880 +9
Misses 3195 3195
Continue to review full report at Codecov.
|
thomasgas
approved these changes
Dec 3, 2018
This was referenced Dec 3, 2018
kbruegge
approved these changes
Dec 12, 2018
watsonjj
added a commit
to watsonjj/ctapipe
that referenced
this pull request
Jan 7, 2019
* master: (22 commits) Remove all hillas_paramters but version 5, fixes cta-observatory#866 (cta-observatory#904) Fix docstring of EventSeeker, fixes cta-observatory#768 (cta-observatory#914) Do not set autodownload, fixes doc build (cta-observatory#910) Import bokeh.palletes correctly, fixes cta-observatory#911 (cta-observatory#912) Fix SST-1M to be DC and not SC. Solves cta-observatory#905 (cta-observatory#908) Fix a few test warnings (cta-observatory#902) Updates of NectarCam and LSTCam real data eventsource class (cta-observatory#812) Implemented FACT image cleaning (cta-observatory#862) remove `config=None, tool=None` in some tests (cta-observatory#897) Remove flow submodule (got moved to its own package) (cta-observatory#893) Cleaning the ctapipe folder. this has been empty for 3 years. (cta-observatory#892) Additional metadata from pyhessio, similar to cta-observatory#655 (cta-observatory#895) add scikit-learn to install_requires (cta-observatory#877) Add .mailmap (cta-observatory#894) Fix subarray peek. No more warnings. (cta-observatory#841) SimTelEventSource using pyeventio (cta-observatory#864) Use sparse neighbor matrix (cta-observatory#826) Add test how it should be (cta-observatory#842) fix errordef > 0. (cta-observatory#839) Fix warning about already closed hessio file (cta-observatory#834) ... # Conflicts: # ctapipe/analysis/camera/chargeresolution.py # ctapipe/tools/extract_charge_resolution.py
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This test shows how one should use our coordinate frames using skycoord