Merge pull request #2337 from clara-escanuela/fc_time_unit

Peak time units conversion for the FlashCam reconstructor

ctapipe/image/extractor.py

@@ -1687,6 +1687,7 @@ def __call__(
             peak_time = adaptive_centroid(
                 d_waveforms, peak_index, leading_edge_rel_descend_limit
             )
+            peak_time = peak_time / (self.sampling_rate_ghz[tel_id] * upsampling)
 
         if gain != 0:
             charge /= gain

ctapipe/image/tests/test_extractor.py

@@ -798,6 +798,22 @@ def test_FC_time(toymodel_mst_fc_time):
     assert_allclose(dl1.peak_time[mask], true_time[mask], rtol=0.1)
     assert dl1.is_valid == True
 
+    extractor = FlashCamExtractor(
+        subarray=subarray, upsampling=1, leading_edge_timing=True
+    )
+    broken_pixels = np.zeros(waveforms.shape[0], dtype=bool)
+    dl1 = extractor(waveforms, tel_id, selected_gain_channel, broken_pixels)
+    assert_allclose(dl1.peak_time[mask], true_time[mask], rtol=0.1)
+    assert dl1.is_valid == True
+
+    extractor = FlashCamExtractor(
+        subarray=subarray, upsampling=1, leading_edge_timing=False
+    )
+    broken_pixels = np.zeros(waveforms.shape[0], dtype=bool)
+    dl1 = extractor(waveforms, tel_id, selected_gain_channel, broken_pixels)
+    assert_allclose(dl1.peak_time[mask], true_time[mask], rtol=0.1)
+    assert dl1.is_valid == True
+
     extractor = FlashCamExtractor(subarray=subarray, leading_edge_timing=False)
     broken_pixels = np.zeros(waveforms.shape[0], dtype=bool)
     dl1 = extractor(waveforms, tel_id, selected_gain_channel, broken_pixels)

docs/changes/2337.bug.rst

@@ -0,0 +1 @@
+Fix peak time units of FlashCamExtractor (See https://github.com/cta-observatory/ctapipe/issues/2336)