Merge pull request #2354 from cta-observatory/tel_coord_reference_loc…

…ation

Fill reference_location into SubarrayDescription.tel_coords

ctapipe/instrument/subarray.py

@@ -154,7 +154,9 @@ def tel_coords(self):
         pos_y = [p[1].to_value(u.m) for p in self.positions.values()]
         pos_z = [p[2].to_value(u.m) for p in self.positions.values()]
 
-        return SkyCoord(x=pos_x, y=pos_y, z=pos_z, unit=u.m, frame=GroundFrame())
+        frame = GroundFrame(reference_location=self.reference_location)
+
+        return SkyCoord(x=pos_x, y=pos_y, z=pos_z, unit=u.m, frame=frame)
 
     @lazyproperty
     def tel_ids(self):

ctapipe/instrument/tests/test_subarray.py

@@ -15,6 +15,8 @@
     TelescopeDescription,
 )
 
+LOCATION = EarthLocation(lon=-17 * u.deg, lat=28 * u.deg, height=2200 * u.m)
+
 
 def create_subarray(tel_type, n_tels=10):
     """generate a simple subarray for testing purposes"""
@@ -31,11 +33,7 @@ def create_subarray(tel_type, n_tels=10):
         "test array",
         tel_positions=pos,
         tel_descriptions=tel,
-        reference_location=EarthLocation(
-            lon=-17 * u.deg,
-            lat=28 * u.deg,
-            height=2200 * u.m,
-        ),
+        reference_location=LOCATION,
     )
 
 
@@ -65,6 +63,8 @@ def test_subarray_description(prod5_mst_nectarcam):
     assert isinstance(sub.tel_coords, SkyCoord)
     assert len(sub.tel_coords) == n_tels
 
+    assert sub.tel_coords.reference_location == LOCATION
+
     subsub = sub.select_subarray([2, 3, 4, 6], name="newsub")
     assert subsub.n_tels == 4
     assert set(subsub.tels.keys()) == {2, 3, 4, 6}

docs/changes/2354.bugfix.rst

@@ -0,0 +1 @@
+Correctly fill ``reference_location`` for ``SubarrayDescription.tel_coords``.