Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Abstract DataVolumeReducer instantiates TailCutsImageCleaner #1399

Closed
maxnoe opened this issue Jul 23, 2020 · 0 comments
Closed

Abstract DataVolumeReducer instantiates TailCutsImageCleaner #1399

maxnoe opened this issue Jul 23, 2020 · 0 comments
Assignees
@Hckjs

Comments

@maxnoe
Copy link
Member

maxnoe commented Jul 23, 2020

In it's __init__ method, the DataVolumeReducer instantiates a TailCutsImageCleaner, which should belong only to the TailCutsDataVolumeReducer, not the base class.
Hckjs added a commit that referenced this issue Jul 31, 2020
@Hckjs
Moved TailCutsImageCleaner from DataVolumeReducer to TailCutsDataVolu…
bdd0c83 
…meReducer, fixes #1399

- Created new __init__ for TailCutsDataVolumeReducer which now instantiates TailCutsImageCleaner
- Put also inst image_extractor into this __init__
@Hckjs Hckjs mentioned this issue Jul 31, 2020
Merged
@kosack kosack closed this as completed in 060a2f0 Sep 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Hckjs Hckjs

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@maxnoe @Hckjs