Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change definition of leakage pixels from number of pixels in camera to number of pixels after cleaning? #2345

Closed
maxnoe opened this issue Jun 5, 2023 · 0 comments · Fixed by #2432

Comments

@maxnoe
Copy link
Member

maxnoe commented Jun 5, 2023

Currently, the two leakage_pixels_width_{1,2} features are defined as the number of pixels after cleaning in the border of the camera divided by the number of pixels of the camera.

I think it would be a better parameter for checks / quality queries etc. if it was the number of pixels after cleaning, i.e. np.count_nonzero(cleaning_mask) instead of geometry.n_pixels.

@maxnoe maxnoe linked a pull request Oct 27, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant