Change definition of leakage_pixel_{1,2} #2432
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I didn't need to change a unit test, which means the current definition is not really tested... |
maxnoe
force-pushed
the
change_leakage_pixel_definition
branch
from
dbe2776
to
a856cb5
Compare
maxnoe
force-pushed
the
change_leakage_pixel_definition
branch
from
a856cb5
to
b3dbbc9
Compare
|
Proper test for leakage using artificial, simple images and changelog entry added. Please review. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2432 +/- ##
=======================================
Coverage 92.48% 92.48%
=======================================
Files 234 234
Lines 19831 19853 +22
=======================================
+ Hits 18340 18362 +22
Misses 1491 1491 ☔ View full report in Codecov by Sentry. |
Tobychev
approved these changes
Nov 24, 2023
kosack
approved these changes
Dec 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.