Restore apply_time_delta_cleaning as a public method #1106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Are there any tests for this function? |
Codecov Report
@@ Coverage Diff @@
## master #1106 +/- ##
==========================================
+ Coverage 84.48% 84.51% +0.03%
==========================================
Files 182 182
Lines 11220 11242 +22
==========================================
+ Hits 9479 9501 +22
Misses 1741 1741
Continue to review full report at Codecov.
|
kosack
requested changes
Jul 15, 2019
kosack
reviewed
Jul 15, 2019
maxnoe
approved these changes
Jul 16, 2019
kosack
approved these changes
Jul 16, 2019
watsonjj
added a commit
to watsonjj/ctapipe
that referenced
this pull request
Jul 16, 2019
* upstream/master: Restore apply_time_delta_cleaning as a public method (cta-observatory#1106) Update mailmap (cta-observatory#1103)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
apply_time_delta_cleaningis a useful function that we started utilising in the CHEC cleaning. I suggest it is restored as a public method.