Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Monitoring container to MC data #1115

Merged
merged 1 commit into from
Mar 5, 2020

Conversation

FrancaCassol
Copy link
Contributor

Waiting for a better solution concerning the handing of Monitoring data in ctapipe, I propose to change the DataContainer() in simteleventsource.py with an EventAndMonDataContainer() .
This should permit to test the calibration tools with MC data following the same procedure used for real data.

…e able to

test calibration tools with MC data
@codecov
Copy link

codecov bot commented Jul 30, 2019

Codecov Report

Merging #1115 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1115   +/-   ##
=======================================
  Coverage   85.81%   85.81%           
=======================================
  Files         182      182           
  Lines       11299    11299           
=======================================
  Hits         9696     9696           
  Misses       1603     1603
Impacted Files Coverage Δ
ctapipe/io/simteleventsource.py 98.5% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e84eadc...c5fe5fe. Read the comment docs.

@kosack
Copy link
Contributor

kosack commented Jul 31, 2019

Is the idea then to later fill the mon containers from simulations?

@FrancaCassol
Copy link
Contributor Author

Exactly.

@FrancaCassol
Copy link
Contributor Author

Hi @kosack,

could you please merge this PR?
Thanks

@maxnoe
Copy link
Member

maxnoe commented Feb 20, 2020

This only exchanges the class of this container in the SimtelEventSource.
It does not fill it.

What is the reason, the the mon field is not just added to DataContainer?

@FrancaCassol
Copy link
Contributor Author

Hi @maxnoe,

This only exchanges the class of this container in the SimtelEventSource.
It does not fill it.

the container will be filled by the calibration scripts (as for the data).

What is the reason, the the mon field is not just added to DataContainer?

I made this choice to separate the event and the monitoring level. As said, this
is surely not the final/better solution, but it works fine at least at R1 level.

@kosack kosack merged commit ea4461b into cta-observatory:master Mar 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants