Combine sample loops #1146
Merged
Combine sample loops #1146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to extract_around_peak
…ample_loops * remotes/upstream/master: Remove 3-dimension extractors (cta-observatory#1144) Add provenance.log to .gitignore (cta-observatory#1145) # Conflicts: # ctapipe/image/extractor.py
…to extract_around_peak
kosack
previously approved these changes
Oct 23, 2019
24 tasks
Codecov Report
@@ Coverage Diff @@
## master #1146 +/- ##
=========================================
Coverage ? 85.89%
=========================================
Files ? 182
Lines ? 11365
Branches ? 0
=========================================
Hits ? 9762
Misses ? 1603
Partials ? 0
Continue to review full report at Codecov.
|
…ample_loops * remotes/upstream/master: Add comments to test Replaced test with generic waveform that goes from positive to negative in window Change test for test_extract_pulse_time_around_peak_with_negative to use the example_event Add condition to only include positive samples in weighting Create test for checking for extreme values from extract_pulse_time_around_peak # Conflicts: # ctapipe/image/tests/test_extractor.py
kosack
approved these changes
Nov 12, 2019
thomasarmstrong
approved these changes
Nov 12, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sum_samples_around_peakandextract_pulse_around_peakperform similar operation and can be combined so there i only one loop over samples