Return global value from TelescopeParameterLookup when passed None #1173
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1173 +/- ##
==========================================
+ Coverage 85.84% 86.03% +0.19%
==========================================
Files 182 182
Lines 11472 11502 +30
==========================================
+ Hits 9848 9896 +48
+ Misses 1624 1606 -18
Continue to review full report at Codecov.
|
kosack
approved these changes
Nov 14, 2019
thomasarmstrong
approved these changes
Nov 15, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a global value is set in the TelescopeParameter defaults (e.g.
default_value=[("type", "*", value)], this PR adds the ability to retrieve that value from the TelescopeParameter in the absence of any subarray information. This then allows, for example, an IntTelescopeParameter to behave as a normal Int traitlet if there is no subarray information available.