Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extra TelescopeParameter use cases #1175

Merged
merged 6 commits into from
Nov 19, 2019
Merged

Conversation

watsonjj
Copy link
Contributor

This PR ensures TelescopeParameter:

  • Can be correctly set via the args of a Component (correctly setting up TelescopeParameterLookup._subarray_global_value)
  • Retains subarray description when the TelescopeParameter defaults are changed

@codecov
Copy link

codecov bot commented Nov 16, 2019

Codecov Report

Merging #1175 into master will increase coverage by 0.03%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1175      +/-   ##
==========================================
+ Coverage   86.03%   86.06%   +0.03%     
==========================================
  Files         182      182              
  Lines       11502    11534      +32     
==========================================
+ Hits         9896     9927      +31     
- Misses       1606     1607       +1
Impacted Files Coverage Δ
ctapipe/core/traits.py 97.65% <100%> (-0.7%) ⬇️
ctapipe/core/tests/test_traits.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1144267...1e4268b. Read the comment docs.

@watsonjj watsonjj merged commit 2805b0b into cta-observatory:master Nov 19, 2019
@watsonjj watsonjj deleted the telparam3 branch April 15, 2020 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants