-
Notifications
You must be signed in to change notification settings - Fork 266
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove unused and untested muon fitting code #1254
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If it's not being used elsewhere, I'm ok with it.
At least not in the LST muon code |
Which I'm going to refactor as well along with this... |
return result | ||
|
||
|
||
def efficiency_fit( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
isn't this efficiency_fit
the one used to calculate the muon_efficiency
given as the output of the muon code?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, this is a different, untested function doing the same thing.
looks like you need to remove
Or alternately, mention this reference somewhere. |
893b985
Codecov Report
@@ Coverage Diff @@
## master #1254 +/- ##
==========================================
+ Coverage 86.78% 87.30% +0.51%
==========================================
Files 192 192
Lines 11967 12129 +162
==========================================
+ Hits 10386 10589 +203
+ Misses 1581 1540 -41
Continue to review full report at Codecov.
|
@kosack could you re-approve |
First step in refactoring of the muon code.
This removed a bunch of unused and untested functions, added by myself four years ago.
Maybe I'll add some of these back, but then by integrating it with the other code and with tests added.
So for now, let's just purge this.