Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add telescope trigger times, move event type to trigger #1322

Merged
merged 4 commits into from
May 13, 2020

Conversation

maxnoe
Copy link
Member

@maxnoe maxnoe commented May 12, 2020

Needed for #1163

This adds per telescope trigger times to the trigger container and fills them in the simtel event source.

It also moves the event type to the trigger information (from index) and removes the telescope_type_id from the index.

@maxnoe maxnoe requested review from kosack and watsonjj May 12, 2020 14:42
kosack
kosack previously approved these changes May 12, 2020
@codecov
Copy link

codecov bot commented May 12, 2020

Codecov Report

Merging #1322 into master will increase coverage by 0.00%.
The diff coverage is 99.20%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1322   +/-   ##
=======================================
  Coverage   90.92%   90.92%           
=======================================
  Files         179      179           
  Lines       12149    12164   +15     
=======================================
+ Hits        11046    11060   +14     
- Misses       1103     1104    +1     
Impacted Files Coverage Δ
ctapipe/io/toymodel.py 94.44% <ø> (ø)
ctapipe/tools/display_summed_images.py 89.09% <ø> (-1.82%) ⬇️
ctapipe/tools/muon_reconstruction.py 90.98% <ø> (-0.08%) ⬇️
ctapipe/io/simteleventsource.py 94.66% <93.33%> (+0.07%) ⬆️
ctapipe/containers.py 100.00% <100.00%> (ø)
ctapipe/io/eventsource.py 92.95% <100.00%> (ø)
ctapipe/io/tests/test_event_source.py 96.26% <100.00%> (ø)
ctapipe/io/tests/test_simteleventsource.py 100.00% <100.00%> (ø)
ctapipe/tools/display_events_single_tel.py 71.60% <100.00%> (ø)
ctapipe/tools/dump_triggers.py 86.66% <100.00%> (ø)
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7383566...8d0c162. Read the comment docs.

@maxnoe maxnoe requested a review from kosack May 12, 2020 15:40
@maxnoe maxnoe merged commit d62663b into master May 13, 2020
@maxnoe maxnoe deleted the telescope_event_header branch May 13, 2020 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants