Use setuptools_scm for versioning, fixes #1333

[maxnoe]

No description provided.

[codecov]

Codecov Report

Merging #1334 (0efd086) into master (cb1dace) will increase coverage by 0.19%.
The diff coverage is 50.00%.

@@            Coverage Diff             @@
##           master    #1334      +/-   ##
==========================================
+ Coverage   90.78%   90.97%   +0.19%     
==========================================
  Files         188      189       +1     
  Lines       13562    13510      -52     
==========================================
- Hits        12312    12291      -21     
+ Misses       1250     1219      -31     

Impacted Files	Coverage Δ
ctapipe/version.py	36.36% <33.33%> (-4.82%)	⬇️
ctapipe/_dev_version.py	60.00% <60.00%> (ø)
ctapipe/__init__.py	100.00% <100.00%> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cb1dace...0efd086. Read the comment docs.

[kosack]

please add a PR description of what this solves

[kosack]

could you merge in the master and fix conflicts? I'll take a look at this soon

[maxnoe]

@kosack I rechecked with the last astropy issues/PRs and implemented what they do, which makes sense I think.
So it behaves now like this:

• If installed locally, we use setuptools_scm via _dev_version.py This file is excluded from distribution (sdist / wheel), so will not be included in a pypi upload. Not excluding setuptools scm for dists lead to some weird issues for astropy, so this is avoided now.

• When building the dists, a file _version.py with just the version information is created. This is used for version information in releases

• When neither is available, a clear warning is given and version = 0.0.0 is set. The only scenario this happens in should be if people try to install ctapipe through a release tarball autogenerated by github (this file cannot contain the autogenerated file and cannot contain git meta information, so this is just impossible). We should probably also add a warning at the bottom of each github release, that these tar balls should not be used to install ctapipe.

[maxnoe]

Ah, we could also think about uploading the sdist using the github releases plugin for pypi, so we have a functioning tarball on github (but just using pypi / conda is also fine I think)