Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix bug where image was 64-bit in case where no extraction is needed #1339

Merged
merged 3 commits into from
May 18, 2020

Conversation

kosack
Copy link
Contributor

@kosack kosack commented May 18, 2020

No description provided.

@kosack kosack requested a review from watsonjj as a code owner May 18, 2020 13:21
@kosack
Copy link
Contributor Author

kosack commented May 18, 2020

we're missing a test for telescopes with no extraction needed. Though I guess the tool test will fail in this case.

@codecov
Copy link

codecov bot commented May 18, 2020

Codecov Report

Merging #1339 into master will decrease coverage by 0.00%.
The diff coverage is 90.15%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1339      +/-   ##
==========================================
- Coverage   91.05%   91.05%   -0.01%     
==========================================
  Files         179      179              
  Lines       12192    12205      +13     
==========================================
+ Hits        11102    11113      +11     
- Misses       1090     1092       +2     
Impacted Files Coverage Δ
ctapipe/calib/camera/flatfield.py 95.04% <ø> (ø)
ctapipe/core/container.py 88.35% <ø> (ø)
ctapipe/image/extractor.py 86.00% <0.00%> (-0.87%) ⬇️
ctapipe/image/hillas.py 98.07% <90.90%> (ø)
ctapipe/io/tests/test_hdf5.py 97.79% <94.73%> (ø)
ctapipe/calib/camera/calibrator.py 100.00% <100.00%> (ø)
ctapipe/calib/camera/pedestals.py 94.94% <100.00%> (ø)
ctapipe/calib/camera/tests/test_calibrator.py 100.00% <100.00%> (ø)
ctapipe/containers.py 100.00% <100.00%> (ø)
ctapipe/core/tests/test_traits.py 100.00% <100.00%> (ø)
... and 19 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 10b058f...a206c5a. Read the comment docs.

@kosack kosack added this to the v0.8.0 milestone May 18, 2020
@maxnoe maxnoe merged commit 87bf027 into cta-observatory:master May 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants