Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add vitables to user environment #1344

Merged
merged 1 commit into from
May 20, 2020

Conversation

kosack
Copy link
Contributor

@kosack kosack commented May 20, 2020

fixes #1340 , Just adds the vitables app (viewer for HDF5 files like those produced by ctapipe) to environment.yml

Rationale: we currently ask users & developers to set up their environment using environment.yml (rather than just conda install ctapipe), which includes packages that go beyond the required ctapipe dependencies, adding useful utilities like pandas and jupyter (also needed for documentation building). This env will likely also be published on anaconda.org (as ctapipe-0.8-env or similar), for easy user setup.

In the future, we might want to separate the testing environment from the recommended user environment, but for now they are the same.

@codecov
Copy link

codecov bot commented May 20, 2020

Codecov Report

Merging #1344 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1344   +/-   ##
=======================================
  Coverage   91.10%   91.10%           
=======================================
  Files         183      183           
  Lines       12548    12548           
=======================================
  Hits        11432    11432           
  Misses       1116     1116           
Impacted Files Coverage Δ
ctapipe/tools/stage1.py 85.59% <ø> (ø)
ctapipe/core/container.py 89.04% <100.00%> (ø)
ctapipe/io/hdf5tableio.py 95.00% <100.00%> (ø)
ctapipe/io/tests/test_hdf5.py 97.87% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ccf2b3e...af5d8e0. Read the comment docs.

@maxnoe maxnoe merged commit 3688ee3 into cta-observatory:master May 20, 2020
@kosack kosack deleted the add_vitables_to_user_env branch May 20, 2020 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

adding vitables into environment file
3 participants