Add support to read from prefixed columns #1364
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1364 +/- ##
==========================================
+ Coverage 90.88% 90.91% +0.03%
==========================================
Files 184 184
Lines 12645 12676 +31
==========================================
+ Hits 11492 11524 +32
+ Misses 1153 1152 -1
Continue to review full report at Codecov.
|
LukasNickel
force-pushed
the
prefixed_container_reading
branch
from
a35f121
to
1d685ec
Compare
LukasNickel
force-pushed
the
prefixed_container_reading
branch
from
1d685ec
to
3f2e41c
Compare
|
Does anyone know why codacy is still complaining? |
Yes, you changed the signature only of the hdf table reader, not of the base class. Methods should have the same signatures for all base classes. |
LukasNickel
commented
Jun 12, 2020
kosack
previously approved these changes
Jun 16, 2020
maxnoe
reviewed
Jun 16, 2020
maxnoe
reviewed
Jun 16, 2020
|
I am pretty sure codacy stopped complaining the last time I visited this. |
Merged
kosack
approved these changes
Jun 19, 2020
LukasNickel
requested review from
vuillaut and
maxnoe
and removed request for
maxnoe
maxnoe
approved these changes
Jun 26, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #1360 in order to work towards a DL1EventSource.
HDF5TableReader.read()method now has an additional, optional argumentprefixprefix=False: No prefix. This is the default, because per default the writer does not add a prefix as wellprefix=True: Using the container prefixprefix="my_prefix": Using a custom prefixThis enables the reading of the image parameter containers, that are written by the stage1 tool, but support for reading into multiple containers at once is still missing.