-
Notifications
You must be signed in to change notification settings - Fork 266
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mask for muons, fixes #1373 #1389
Conversation
several issues with units (e.g. radians & deg)
Maybe you could also directly add, that the |
The other failing tests are due to a matplotlib update and are fixed in #1387. |
Codecov Report
@@ Coverage Diff @@
## master #1389 +/- ##
==========================================
- Coverage 90.91% 90.88% -0.04%
==========================================
Files 184 184
Lines 12677 12720 +43
==========================================
+ Hits 11525 11560 +35
- Misses 1152 1160 +8
Continue to review full report at Codecov.
|
@moralejo if you merge the master again, the tests should pass |
…nto mask_for_muons
What input does that expect? simtel file? It is not specified in the help. |
@moralejo It uses the generic I'll also add the check to this tool that was added to the stage1 process. |
Solves #1373