Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mask for muons, fixes #1373 #1389

Merged
merged 22 commits into from
Jul 22, 2020
Merged

Conversation

moralejo
Copy link
Contributor

Solves #1373

@maxnoe maxnoe changed the title Mask for muons Mask for muons, fixes #1373 Jul 20, 2020
@maxnoe
Copy link
Member

maxnoe commented Jul 20, 2020

Maybe you could also directly add, that the ctapipe/tools/muon_reconstruction.py uses this?

ctapipe/image/muon/intensity_fitter.py Outdated Show resolved Hide resolved
@maxnoe
Copy link
Member

maxnoe commented Jul 20, 2020

The other failing tests are due to a matplotlib update and are fixed in #1387.

@codecov
Copy link

codecov bot commented Jul 20, 2020

Codecov Report

Merging #1389 into master will decrease coverage by 0.03%.
The diff coverage is 83.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1389      +/-   ##
==========================================
- Coverage   90.91%   90.88%   -0.04%     
==========================================
  Files         184      184              
  Lines       12677    12720      +43     
==========================================
+ Hits        11525    11560      +35     
- Misses       1152     1160       +8     
Impacted Files Coverage Δ
ctapipe/image/muon/intensity_fitter.py 90.54% <20.00%> (-2.47%) ⬇️
ctapipe/tools/tests/test_tools.py 97.43% <88.57%> (-2.57%) ⬇️
ctapipe/io/simteleventsource.py 94.64% <100.00%> (ø)
ctapipe/io/tests/test_simteleventsource.py 100.00% <100.00%> (ø)
ctapipe/tools/stage1.py 85.82% <100.00%> (+0.23%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8205d4d...d07e084. Read the comment docs.

@maxnoe
Copy link
Member

maxnoe commented Jul 20, 2020

@moralejo if you merge the master again, the tests should pass

@moralejo
Copy link
Contributor Author

Maybe you could also directly add, that the ctapipe/tools/muon_reconstruction.py uses this?

What input does that expect? simtel file? It is not specified in the help.

@dneise dneise linked an issue Jul 21, 2020 that may be closed by this pull request
@maxnoe
Copy link
Member

maxnoe commented Jul 21, 2020

@moralejo It uses the generic EventSource, so any event source providing r1/dl0 should work.

I'll also add the check to this tool that was added to the stage1 process.

@kosack kosack merged commit 597c1dc into cta-observatory:master Jul 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Passing a mask to MuonIntensityFitter?
3 participants