Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix writing of camera description in subarray.to_hdf, fixes #1422 #1423

Merged
merged 2 commits into from
Sep 16, 2020

Conversation

maxnoe
Copy link
Member

@maxnoe maxnoe commented Sep 16, 2020

No description provided.

@codecov
Copy link

codecov bot commented Sep 16, 2020

Codecov Report

Merging #1423 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1423   +/-   ##
=======================================
  Coverage   90.90%   90.90%           
=======================================
  Files         184      184           
  Lines       12882    12885    +3     
=======================================
+ Hits        11710    11713    +3     
  Misses       1172     1172           
Impacted Files Coverage Δ
ctapipe/instrument/subarray.py 94.35% <100.00%> (-0.13%) ⬇️
ctapipe/instrument/tests/test_subarray.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 052fe3b...f10ff4d. Read the comment docs.

@maxnoe maxnoe requested a review from kosack September 16, 2020 09:03
@kosack kosack merged commit 805a231 into master Sep 16, 2020
@maxnoe maxnoe deleted the fix_camera_writing branch September 16, 2020 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants