Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require python >= 3.7 #1467

Merged
merged 9 commits into from
Oct 21, 2020
Merged

Require python >= 3.7 #1467

merged 9 commits into from
Oct 21, 2020

Conversation

maxnoe
Copy link
Member

@maxnoe maxnoe commented Oct 16, 2020

This adresses #1466 , so dropping 3.6 for the next release.

There was also a bug in ci/install.sh resulting in not installing the correct python version for conda builds (so we didn't even test on 3.6 since conda switched to 3.7 by default)

@codecov
Copy link

codecov bot commented Oct 16, 2020

Codecov Report

Merging #1467 into master will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1467      +/-   ##
==========================================
- Coverage   91.17%   91.17%   -0.01%     
==========================================
  Files         183      183              
  Lines       12830    12871      +41     
==========================================
+ Hits        11698    11735      +37     
- Misses       1132     1136       +4     
Impacted Files Coverage Δ
ctapipe/calib/camera/calibrator.py 94.44% <0.00%> (-4.05%) ⬇️
ctapipe/calib/camera/tests/test_calibrator.py 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f94fe68...216e372. Read the comment docs.

kosack
kosack previously approved these changes Oct 19, 2020
@maxnoe maxnoe changed the title Bump python versions on travis by one release Require python >= 3.7 Oct 19, 2020
@dneise
Copy link
Member

dneise commented Oct 20, 2020

There is a timeout in conda env create -n cta-dev --file environment.yml on Travis when building for Py3.8

Is this reason for concern? I restarted the build this morning once .. hoping it was just a mishap on travis.... no luck

ci/install.sh Show resolved Hide resolved
@maxnoe
Copy link
Member Author

maxnoe commented Oct 20, 2020

@dneise it worked yesterday with the first commit... Ah, but that probably was still using the wrong version.

@maxnoe
Copy link
Member Author

maxnoe commented Oct 20, 2020

It is a missing eventio for python 3.8 I think.

@maxnoe maxnoe requested a review from dneise October 20, 2020 09:00
@dneise
Copy link
Member

dneise commented Oct 20, 2020

Erm .. I see to be missing the point here ... it is still failing no?

@maxnoe
Copy link
Member Author

maxnoe commented Oct 20, 2020

Yes, because there is no conda package of eventio for python 3.8. @kosack will upload it shortly.

@dneise
Copy link
Member

dneise commented Oct 20, 2020

Ah I see ... thanks

.travis.yml Outdated Show resolved Hide resolved
ci/install.sh Outdated Show resolved Hide resolved
@maxnoe maxnoe requested a review from vuillaut October 20, 2020 20:12
@maxnoe maxnoe merged commit 1032f0e into master Oct 21, 2020
@maxnoe maxnoe deleted the travis_python branch October 21, 2020 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants