-
Notifications
You must be signed in to change notification settings - Fork 266
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Require python >= 3.7 #1467
Require python >= 3.7 #1467
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1467 +/- ##
==========================================
- Coverage 91.17% 91.17% -0.01%
==========================================
Files 183 183
Lines 12830 12871 +41
==========================================
+ Hits 11698 11735 +37
- Misses 1132 1136 +4
Continue to review full report at Codecov.
|
There is a timeout in Is this reason for concern? I restarted the build this morning once .. hoping it was just a mishap on travis.... no luck |
@dneise it worked yesterday with the first commit... Ah, but that probably was still using the wrong version. |
It is a missing eventio for python 3.8 I think. |
Erm .. I see to be missing the point here ... it is still failing no? |
Yes, because there is no conda package of eventio for python 3.8. @kosack will upload it shortly. |
Ah I see ... thanks |
This adresses #1466 , so dropping 3.6 for the next release.
There was also a bug in
ci/install.sh
resulting in not installing the correct python version for conda builds (so we didn't even test on 3.6 since conda switched to 3.7 by default)