Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add camera frame in TelescopeDescription.from_name #1496

Merged
merged 1 commit into from
Nov 4, 2020
Merged

Conversation

maxnoe
Copy link
Member

@maxnoe maxnoe commented Oct 28, 2020

As needed to transform into TelescopeFrame

@codecov
Copy link

codecov bot commented Oct 28, 2020

Codecov Report

Merging #1496 into master will increase coverage by 0.13%.
The diff coverage is 96.47%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1496      +/-   ##
==========================================
+ Coverage   91.17%   91.31%   +0.13%     
==========================================
  Files         183      183              
  Lines       12830    12950     +120     
==========================================
+ Hits        11698    11825     +127     
+ Misses       1132     1125       -7     
Impacted Files Coverage Δ
ctapipe/conftest.py 100.00% <ø> (ø)
ctapipe/image/timing.py 92.30% <ø> (-0.55%) ⬇️
ctapipe/tools/extract_charge_resolution.py 49.18% <50.00%> (+0.79%) ⬆️
ctapipe/tools/bokeh/file_viewer.py 75.63% <66.66%> (ø)
ctapipe/calib/camera/calibrator.py 94.44% <83.33%> (-4.05%) ⬇️
ctapipe/core/traits.py 95.33% <90.00%> (+0.49%) ⬆️
ctapipe/core/component.py 97.01% <92.30%> (+0.29%) ⬆️
ctapipe/calib/camera/flatfield.py 97.95% <100.00%> (+2.90%) ⬆️
ctapipe/calib/camera/pedestals.py 97.91% <100.00%> (+2.96%) ⬆️
ctapipe/calib/camera/tests/test_calibrator.py 100.00% <100.00%> (ø)
... and 32 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4d7daa6...e9fb00a. Read the comment docs.

@maxnoe maxnoe merged commit d716555 into master Nov 4, 2020
@maxnoe maxnoe deleted the from_name_frame branch November 4, 2020 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants