Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure get_dataset_path returns Path, fix event source test, fixes #1517 #1519

Merged
merged 1 commit into from
Nov 17, 2020

Conversation

maxnoe
Copy link
Member

@maxnoe maxnoe commented Nov 16, 2020

fixes #1517

@maxnoe maxnoe added this to the v0.10.0 milestone Nov 16, 2020
@codecov
Copy link

codecov bot commented Nov 16, 2020

Codecov Report

Merging #1519 (2adc638) into master (e6ddf72) will decrease coverage by 0.00%.
The diff coverage is 50.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1519      +/-   ##
==========================================
- Coverage   90.41%   90.41%   -0.01%     
==========================================
  Files         194      194              
  Lines       13867    13860       -7     
==========================================
- Hits        12538    12531       -7     
  Misses       1329     1329              
Impacted Files Coverage Δ
ctapipe/utils/datasets.py 90.09% <0.00%> (ø)
ctapipe/io/tests/test_event_source.py 96.46% <100.00%> (-0.21%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e6ddf72...2adc638. Read the comment docs.

Copy link
Member

@HealthyPear HealthyPear left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry I didn't get it from the issue: is input_url supposed to overwrite the dataset in config or the other way around?

@maxnoe
Copy link
Member Author

maxnoe commented Nov 17, 2020

It is supposed to. More explicit should override less explicit. So kwarg overrides config overrides default.

@maxnoe
Copy link
Member Author

maxnoe commented Nov 17, 2020

Sorry, I mixed two things here, which where connected on my machine.

This is both the fix for #1517 and the issue mentioned in the title that get_dataset_path would return a str when it found the file in ctapipe-extra and a Path if found anywhere else.

@maxnoe maxnoe merged commit 6987f32 into master Nov 17, 2020
@maxnoe maxnoe deleted the fix_source_test branch November 17, 2020 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

test_event_source_config looks broken to me.
3 participants