Add brightest_island function #1587
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1587 +/- ##
==========================================
+ Coverage 90.43% 90.44% +0.01%
==========================================
Files 186 186
Lines 13862 13882 +20
==========================================
+ Hits 12536 12556 +20
Misses 1326 1326
Continue to review full report at Codecov.
|
ctapipe/image/morphology.py
Outdated
| island_brightness = np.zeros(n_islands + 1) | ||
| np.add.at(island_brightness, island_labels[mask], image[mask]) | ||
|
|
||
| brightest_island = np.argmax(island_brightness) |
There was a problem hiding this comment.
Shouldn't name your variable brightest_island, as that is also the function name
There was a problem hiding this comment.
That's actually not a problem, since it only assigns a variable in the local scope of the function (and the function is not recursive).
However, to avoid confusion, I changed the variable name.
There was a problem hiding this comment.
Thanks. it was more to avoid confusion and the linter complaining
ctapipe/image/morphology.py
Outdated
| island_brightness = np.zeros(n_islands + 1) | ||
| np.add.at(island_brightness, island_labels[mask], image[mask]) | ||
|
|
||
| brightest_island = np.argmax(island_brightness) |
No description provided.