Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Vectorize operations in HillasReconstructor #2036

Merged
merged 11 commits into from
Sep 23, 2022
Merged

Vectorize operations in HillasReconstructor #2036

merged 11 commits into from
Sep 23, 2022

Commits on Sep 23, 2022

  1. Add test for HillasReconstructor in CameraFrame

    @maxnoe
    maxnoe committed Sep 23, 2022
    Configuration menu
    Copy the full SHA
    1b5b417 View commit details
    Browse the repository at this point in the history

  2. Vectorize operations HillasReconstructor 

    This gives me a 5.5 times speed-up compared to current master.
    @maxnoe
    maxnoe committed Sep 23, 2022
    Configuration menu
    Copy the full SHA
    96a44b8 View commit details
    Browse the repository at this point in the history

  3. Use data instead of transforming to spherical

    @maxnoe
    maxnoe committed Sep 23, 2022
    Configuration menu
    Copy the full SHA
    fb8a5a8 View commit details
    Browse the repository at this point in the history

  4. Adjust test tolerances (have to investigate why this fails!)

    @maxnoe
    maxnoe committed Sep 23, 2022
    Configuration menu
    Copy the full SHA
    2a6a5c4 View commit details
    Browse the repository at this point in the history

  5. Use UnitSphericalRepresentation instead of spherical in nominal/teles… 

    …cope frame transforms
    @maxnoe
    maxnoe committed Sep 23, 2022
    Configuration menu
    Copy the full SHA
    50665f7 View commit details
    Browse the repository at this point in the history

  6. Improve units code in ground_frame.py

    @maxnoe
    maxnoe committed Sep 23, 2022
    Configuration menu
    Copy the full SHA
    8896bb4 View commit details
    Browse the repository at this point in the history

  7. Do not create wrap_angle each time

    @maxnoe
    maxnoe committed Sep 23, 2022
    Configuration menu
    Copy the full SHA
    2400bef View commit details
    Browse the repository at this point in the history

  8. Make sure HillasReconstructor az is in [0, 360)

    @maxnoe
    maxnoe committed Sep 23, 2022
    Configuration menu
    Copy the full SHA
    0f5d4c5 View commit details
    Browse the repository at this point in the history

  9. Fix test and revert change of Longitude to Angle

    @maxnoe
    maxnoe committed Sep 23, 2022
    Configuration menu
    Copy the full SHA
    7b35b54 View commit details
    Browse the repository at this point in the history

  10. Remove unused variable

    @maxnoe
    maxnoe committed Sep 23, 2022
    Configuration menu
    Copy the full SHA
    8259b89 View commit details
    Browse the repository at this point in the history

  11. Fix docstring

    @maxnoe
    maxnoe committed Sep 23, 2022
    Configuration menu
    Copy the full SHA
    cf7f20e View commit details
    Browse the repository at this point in the history