Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Load observation info with TableLoader; standardize id fields in containers #2096

Merged
merged 4 commits into from Oct 19, 2022

Conversation

LukasBeiske
Copy link
Contributor

This adds an option to load the observation information from /configuration/observation/observation_block with TableLoader and join it to each event.

This also standardizes the obs_id, event_id and tel_id fields used in some containers to remove mismatching descriptions which led to some warnings when merging different tables.

@codecov
Copy link

codecov bot commented Oct 11, 2022

Codecov Report

Base: 92.51% // Head: 92.52% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (39c06e4) compared to base (89add5c).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2096   +/-   ##
=======================================
  Coverage   92.51%   92.52%           
=======================================
  Files         199      200    +1     
  Lines       16561    16582   +21     
=======================================
+ Hits        15322    15343   +21     
  Misses       1239     1239           
Impacted Files Coverage Δ
ctapipe/containers.py 100.00% <100.00%> (ø)
ctapipe/io/tableloader.py 98.41% <100.00%> (+0.06%) ⬆️
ctapipe/io/tests/test_table_loader.py 99.44% <100.00%> (+0.01%) ⬆️
ctapipe/io/simteleventsource.py 96.05% <0.00%> (-0.02%) ⬇️
ctapipe/coordinates/__init__.py 100.00% <0.00%> (ø)
ctapipe/reco/impact_distance.py
ctapipe/reco/tests/test_impact_distance.py
ctapipe/coordinates/utils.py 100.00% <0.00%> (ø)
ctapipe/coordinates/impact_distance.py 100.00% <0.00%> (ø)
ctapipe/coordinates/tests/test_impact_distance.py 100.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

kosack
kosack previously approved these changes Oct 13, 2022
ctapipe/containers.py Outdated Show resolved Hide resolved
maxnoe
maxnoe previously approved these changes Oct 13, 2022
@maxnoe maxnoe merged commit 05beb25 into cta-observatory:master Oct 19, 2022
@LukasBeiske LukasBeiske deleted the load_pointing branch October 19, 2022 10:16
@nbiederbeck nbiederbeck mentioned this pull request Dec 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants