New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ci pipeline for ctao sonarqube #2214
Conversation
I need to figure out how to incorporate the test coverage here - this should run after the test job, so that the coverage info is available, so probably has to be in the same pipeline as the tests |
You need to declare the coverage xml report as an artifact, which will make it available to the sonarqube stage |
cf11431
to
9fcb903
Compare
pytest says: https://github.com/cta-observatory/ctapipe/actions/runs/6890858501/job/18752250379?pr=2456#step:10:152
But codecov and sonarqube don't see the file: https://github.com/cta-observatory/ctapipe/actions/runs/6890858501/job/18752250379?pr=2456#step:11:33
|
6d94a35
to
715703e
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2214 +/- ##
===========================================
+ Coverage 60.60% 87.96% +27.35%
===========================================
Files 3 231 +228
Lines 33 19768 +19735
===========================================
+ Hits 20 17388 +17368
- Misses 13 2380 +2367 ☔ View full report in Codecov by Sentry. |
321abf1
to
a251a0b
Compare
d0b5ca7
to
2a6771f
Compare
2a6771f
to
76227fb
Compare
I am closing this in favor of #2463 since I am quite convinced now that it won't properly work in our current setup. |
another attempt