Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ci pipeline for ctao sonarqube #2214

Closed
wants to merge 5 commits into from
Closed

Conversation

kosack
Copy link
Contributor

@kosack kosack commented Jan 12, 2023

another attempt

@kosack
Copy link
Contributor Author

kosack commented Jan 13, 2023

I need to figure out how to incorporate the test coverage here - this should run after the test job, so that the coverage info is available, so probably has to be in the same pipeline as the tests

@maxnoe
Copy link
Member

maxnoe commented Nov 15, 2023

I need to figure out how to incorporate the test coverage here - this should run after the test job, so that the coverage info is available, so probably has to be in the same pipeline as the tests

You need to declare the coverage xml report as an artifact, which will make it available to the sonarqube stage

@maxnoe maxnoe force-pushed the ci_pipeline_for_ctao_sonarqube branch from cf11431 to 9fcb903 Compare November 16, 2023 16:05
@Tobychev Tobychev added documentation-only Label that will ensure code tests are skipped and removed documentation-only Label that will ensure code tests are skipped labels Nov 16, 2023
@maxnoe
Copy link
Member

maxnoe commented Nov 16, 2023

pytest says: https://github.com/cta-observatory/ctapipe/actions/runs/6890858501/job/18752250379?pr=2456#step:10:152

---------- coverage: platform linux, python 3.10.13-final-0 ----------
Coverage XML written to file coverage.xml

But codecov and sonarqube don't see the file: https://github.com/cta-observatory/ctapipe/actions/runs/6890858501/job/18752250379?pr=2456#step:11:33

[2023-11-16T12:50:52.721Z] ['error'] There was an error running the uploader: No coverage files located, please try use -f, or change the project root with -R

@maxnoe maxnoe force-pushed the ci_pipeline_for_ctao_sonarqube branch from 6d94a35 to 715703e Compare November 17, 2023 08:59
Copy link

codecov bot commented Nov 17, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (49ab82b) 60.60% compared to head (76227fb) 87.96%.
Report is 2 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #2214       +/-   ##
===========================================
+ Coverage   60.60%   87.96%   +27.35%     
===========================================
  Files           3      231      +228     
  Lines          33    19768    +19735     
===========================================
+ Hits           20    17388    +17368     
- Misses         13     2380     +2367     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@maxnoe maxnoe force-pushed the ci_pipeline_for_ctao_sonarqube branch from 321abf1 to a251a0b Compare November 17, 2023 09:49
@maxnoe maxnoe force-pushed the ci_pipeline_for_ctao_sonarqube branch 2 times, most recently from d0b5ca7 to 2a6771f Compare November 17, 2023 13:36
@maxnoe maxnoe force-pushed the ci_pipeline_for_ctao_sonarqube branch from 2a6771f to 76227fb Compare November 17, 2023 14:00
@maxnoe
Copy link
Member

maxnoe commented Nov 23, 2023

I am closing this in favor of #2463 since I am quite convinced now that it won't properly work in our current setup.

@maxnoe maxnoe closed this Nov 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants