Fix peak_time estimation in FlashCamExtractor #2333
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxnoe
changed the title
maxnoe
reviewed
May 16, 2023
|
Before: After: |
maxnoe
reviewed
May 16, 2023
Co-authored-by: Maximilian Linhoff <maximilian.linhoff@tu-dortmund.de>
maxnoe
reviewed
May 16, 2023
Co-authored-by: Maximilian Linhoff <maximilian.linhoff@tu-dortmund.de>
maxnoe
approved these changes
May 16, 2023
Tobychev
approved these changes
May 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After the extractor optimization, I did not check timing performance again as I only made a few changes in the code. But one of these very small changes caused a problem in the time reconstruction. The unit tests did not identify it because they were not sensitive enough. By adding a new toymodel with a time gradient we can find timing bugs better. I checked the test with the previous implementation (with that wrong line of code) and the test fails (as expected). In fact, the same test with the standard toymodel provided (random true times) passes even when time reconstruction is wrong. I think a further test can also be added to other extractors, to avoid similar problems.