Add fields defined in CTAO DL0 and R1 data models #2338
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxnoe
changed the title
maxnoe
force-pushed
the
ctao_dl0
branch
2 times, most recently
from
ccf3df5
to
2cab3be
Compare
kosack
requested changes
May 31, 2023
maxnoe
force-pushed
the
ctao_dl0
branch
2 times, most recently
from
ed93d63
to
9d2754d
Compare
kosack
previously approved these changes
Jun 2, 2023
kosack
approved these changes
Jul 18, 2023
maxnoe
commented
Aug 28, 2023
| # unset dvr bits for removed pixels | ||
| dl0_pixel_status[~signal_pixels] &= ~np.uint8(PixelStatus.DVR_STATUS) | ||
|
|
||
| event.dl0.tel[tel_id] = DL0CameraContainer( |
There was a problem hiding this comment.
This is a somewhat unrelated improvement. Instead of relying on that the first access of a non-existing container will default initialize it (as Map behaves like a defaultdict), we explicitly create the new container.
This is more efficient (since the defaults don't have to be created before they are overwritten with the actual values) and less error prone (because you can't by accident "inherit" values from before).
See some discussion in #2084
maxnoe
commented
Aug 28, 2023
| Pixel status information | ||
|
|
||
| See DL0 Data Model specification: | ||
| https://redmine.cta-observatory.org/dmsf/files/17552/view |
There was a problem hiding this comment.
Most people developing ctapipe will have access to it and it is the official source for these definitions. I think not including it for reference is worse.
Tobychev
reviewed
Aug 28, 2023
Tobychev
approved these changes
Aug 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.