Remove SimulationConfigContainer.injection_height, add SimulatedShowercontainer.starting_grammage #2343
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rcontainer.starting_grammage
kosack
approved these changes
Jun 2, 2023
|
Does this merit a bump to the data model? It's not a really required part of the data, so maybe not (I mean it doesn't break reading old files, and up to now we don't use this column anywhere). So my feeling would be no, or at least a minor version change rather than major. It's not an issue for this PR, but we should consider bumping it before the next release if there are enough changes |
Tobychev
approved these changes
Jun 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2335