Add support for hillas parameters in TelescopeFrame to CameraDisplay #2347
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
maxnoe
commented
Jun 13, 2023
•
maxnoe
commented
- test
|
Besides the missing telescope frame support, I was annoyed by the text overlapping the ellipse, I now added a bit of code to put it just outside the ellipse, rotated so it never overlaps: hillas_overlay.mp4 |
LukasNickel
previously approved these changes
Jun 13, 2023
|
I imagine this also has to be fixed in the Bokeh version? |
Yes indeed. I will make another PR for the bokeh one |
|
Thinking about it, I think it makes sense to do it together here... |
|
Done |
kosack
approved these changes
Jun 14, 2023
LukasNickel
approved these changes
Jun 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.