Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix removal of telescope events in software trigger, fixes #2356 #2357

Merged
merged 7 commits into from Jun 20, 2023
Merged

Fix removal of telescope events in software trigger, fixes #2356 #2357

merged 7 commits into from Jun 20, 2023

Conversation

maxnoe
Copy link
Member

@maxnoe maxnoe commented Jun 20, 2023

fixes #2356

@maxnoe maxnoe requested a review from kosack June 20, 2023 09:45
@maxnoe maxnoe added this to the v0.19.3 milestone Jun 20, 2023
@maxnoe maxnoe requested a review from LukasNickel June 20, 2023 11:57
LukasNickel
LukasNickel previously approved these changes Jun 20, 2023
View reviewed changes
@maxnoe maxnoe merged commit d39d51c into main Jun 20, 2023
12 checks passed
@maxnoe maxnoe deleted the fix_software_trigger branch June 20, 2023 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tobychev Tobychev Tobychev approved these changes

@LukasNickel LukasNickel LukasNickel approved these changes

@kosack kosack Awaiting requested review from kosack

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.19.3
Development

Successfully merging this pull request may close these issues.

dl1/event/telescope/trigger written for events that should have been removed by the SoftwareTrigger
3 participants
@maxnoe @Tobychev @LukasNickel