Improve docstring and validation of parameters in CameraGeometry #2361
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kosack
previously approved these changes
Jun 20, 2023
maxnoe
force-pushed
the
fix_single_pixel_area
branch
from
89e60e4
to
7d5c256
Compare
maxnoe
force-pushed
the
fix_single_pixel_area
branch
from
7d5c256
to
81f35fe
Compare
Tobychev
reviewed
Jun 20, 2023
| position of each pixel (y-coordinate) | ||
| pix_area : array(float) | ||
| surface area of each pixel, if None will be calculated |
There was a problem hiding this comment.
was this "if not given will be calculated" simply not correct?
There was a problem hiding this comment.
Yes, this got removed a long time ago and made a required argument
LukasNickel
reviewed
Jun 20, 2023
LukasNickel
approved these changes
Jun 20, 2023
kosack
approved these changes
Jun 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.