Remove dump-triggers, enable ctapipe-process to store only trigger and simulation data #2375
Conversation
…move obsolete dump-triggers
|
i didn't check, but I guess the merge tool will work with these files, since this info was already merged? |
|
@kosack Yes, merging works fine |
ctapipe/io/datawriter.py
Outdated
| def _write_trigger(self, writer: TableWriter, event: ArrayEventContainer): | ||
| """ | ||
| Write trigger information | ||
| """ | ||
| self._writer.write( | ||
| table_name="dl1/event/subarray/trigger", | ||
| containers=[event.index, event.trigger], | ||
| ) | ||
|
|
||
| for tel_id, trigger in event.trigger.tel.items(): | ||
| writer.write( | ||
| "dl1/event/telescope/trigger", (_get_tel_index(event, tel_id), trigger) | ||
| ) | ||
|
|
There was a problem hiding this comment.
Quick question for my understanding.
self._write_trigger(self._writer, event) is called in L304, which means
writer=self._writer.
But self._writer is already available inside the function.
In which case do you want to use a different writer with this function?
There was a problem hiding this comment.
This is likely a leftover from the original design of the DataWriter, where I had considered having a writer per table. There may have been some other reason for that design as well, but I don't recall. However, currently only one is used as TableWriter supports writing to multiple tables. We can refactor that later, but I agree here at least you should use writer.write() and not self._writer.write()
There was a problem hiding this comment.
It could have been because DataWriter was meant to support other types of TableWriter in the future as well (only HDF5 is currently implemented, but it would be pretty easy to have other formats). But even then, we could assume the TableWriter itself supports handling of N tables.
There was a problem hiding this comment.
This was a copy paste mistake, I moved the subarray writing from call where it directly accessed self._writer
Will change.
Since this is all internal anyway, I could also just remove the wrote argument though
fixes #2372
Running
ctapipe-process -i <input> -o <output> --no-write-parameterswill result in an output file only containing trigger and simulation information, no any actual processing will happen.