Use int minval instead -1 for invalid telescope ids in SubarrayDescription.tel_index_array, improve docstrings #2376
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tobychev
reviewed
Jul 7, 2023
|
@Tobychev the tests are failing currently.... |
Yeah, but it doesn't look like the failures are related to the changes? At least many look to be of the type "column 'ExtraTreesRegressor_energy' not found", but that looks unrelated to your changes? |
Tobychev
reviewed
Sep 4, 2023
kosack
approved these changes
Sep 7, 2023
Tobychev
approved these changes
Sep 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-1 is a dangerous index for "invalid" since it will silently result in using the last element when used as index.
Replaced by using int minval, which will result in an IndexError and can be easily filtered by checking
index >= 0.