Use intmin for invalid pixel positions, allow empty arguments #2397
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxnoe
force-pushed
the
fix_pix_index
branch
from
0b83f66
to
398f579
Compare
Tobychev
reviewed
Sep 20, 2023
|
Also, this seems to have encountered that same problem with traitlets and the docs that you fixed for #2396 |
maxnoe
force-pushed
the
fix_pix_index
branch
from
398f579
to
5c1d415
Compare
Tobychev
approved these changes
Sep 20, 2023
maxnoe
force-pushed
the
fix_pix_index
branch
from
5c1d415
to
ff7390b
Compare
LukasNickel
approved these changes
Oct 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1828