Include example config for ctapipe-train-disp-reconstructor in quickstart tool #2414
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxnoe
reviewed
Oct 20, 2023
|
|
||
| Included here are also base configurations for training machine learning (ML) | ||
| models for energy regression and gamma/hadron separation. | ||
| models for energy regression, gamma/hadron separation and disp origin reconstruction. |
There was a problem hiding this comment.
I think we should add proper configuration files for use with ctapipe-quickstart, not the unit test files with slimmed down simplified configurations as we have them here.
Ok for now, but maybe add a note that these files are optimized for very fast training for demos and unit tests and will not result in good performance?
|
Is the actual config file missing here, or am I missing something? |
It is there at |
LukasBeiske
changed the title
Tobychev
approved these changes
Oct 20, 2023
maxnoe
approved these changes
Oct 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.