Do not use hidden attribute reconstructor._models in ctapipe-apply-models
#2418
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxnoe
reviewed
Oct 23, 2023
maxnoe
reviewed
Oct 23, 2023
LukasBeiske
force-pushed
the
no_hidden_attr
branch
from
1cdf3d5
to
89f3ac0
Compare
kosack
previously approved these changes
Oct 23, 2023
maxnoe
reviewed
Oct 23, 2023
Tobychev
approved these changes
Oct 23, 2023
maxnoe
approved these changes
Oct 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hidden attributes should not be used outside the class they are defined in. Catching the KeyError is better here.