Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow setting n_jobs on tool invocation #2430

Merged
merged 11 commits into from
Nov 23, 2023
Merged

Allow setting n_jobs on tool invocation #2430

merged 11 commits into from
Nov 23, 2023

Commits on Nov 23, 2023

  1. Allow setting n_jobs on tool invocation 

    - It can be useful to set n_jobs indepently from the config file
- For the sklearn reconstructors this requires setting n_jobs on every
  model, that is attached to the reconstructor
- Fixes #2307
    @LukasNickel
    LukasNickel committed Nov 23, 2023
    Configuration menu
    Copy the full SHA
    f209f54 View commit details
    Browse the repository at this point in the history

  2. Add changelog

    @LukasNickel
    LukasNickel committed Nov 23, 2023
    Configuration menu
    Copy the full SHA
    18818e2 View commit details
    Browse the repository at this point in the history

  3. Add alias

    @LukasNickel
    LukasNickel committed Nov 23, 2023
    Configuration menu
    Copy the full SHA
    a2e6722 View commit details
    Browse the repository at this point in the history

  4. Set n_jobs directly in reconstructor class

    @LukasNickel
    LukasNickel committed Nov 23, 2023
    Configuration menu
    Copy the full SHA
    35226bd View commit details
    Browse the repository at this point in the history

  5. Remove double loop

    @LukasNickel
    LukasNickel committed Nov 23, 2023
    Configuration menu
    Copy the full SHA
    e2863d3 View commit details
    Browse the repository at this point in the history

  6. Use traitlets observe to change value of n_jobs

    @LukasNickel
    LukasNickel committed Nov 23, 2023
    Configuration menu
    Copy the full SHA
    dcf1885 View commit details
    Browse the repository at this point in the history

  7. Clarify help

    @LukasNickel
    LukasNickel committed Nov 23, 2023
    Configuration menu
    Copy the full SHA
    01fa3ae View commit details
    Browse the repository at this point in the history

  8. Set n_jobs to none after training

    @LukasNickel
    LukasNickel committed Nov 23, 2023
    Configuration menu
    Copy the full SHA
    a234c66 View commit details
    Browse the repository at this point in the history

  9. Fix n_jobs for the DispReconstructor 

    - Implement the @observe method there as well, because it is not a
subclass of sklearnreconstructor
    @LukasNickel
    LukasNickel committed Nov 23, 2023
    Configuration menu
    Copy the full SHA
    8f87a8c View commit details
    Browse the repository at this point in the history

  10. Fix docs syntax

    @LukasNickel
    LukasNickel committed Nov 23, 2023
    Configuration menu
    Copy the full SHA
    ad4bd4d View commit details
    Browse the repository at this point in the history

  11. Update ml configs 

    - Move n_jobs from model config to reconstructor config
    @LukasNickel
    LukasNickel committed Nov 23, 2023
    Configuration menu
    Copy the full SHA
    0372d11 View commit details
    Browse the repository at this point in the history