Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to src based repository structure #2459

Merged
merged 3 commits into from Jan 24, 2024
Merged

Switch to src based repository structure #2459

merged 3 commits into from Jan 24, 2024

Conversation

maxnoe
Copy link
Member

@maxnoe maxnoe commented Nov 17, 2023

Immediate issue:

Since all files were moved, they were all "touched" in this PR, which triggered the pre-commit hook to reformat all files.

So they are not just moved but also reformatted.

@maxnoe
Copy link
Member Author

maxnoe commented Nov 17, 2023

But actually the changes are very small, so maybe not that large of an issue

Copy link

codecov bot commented Nov 17, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (d0ed459) 92.52% compared to head (5d2aa9e) 92.52%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2459      +/-   ##
==========================================
- Coverage   92.52%   92.52%   -0.01%     
==========================================
  Files         234      234              
  Lines       20006    20005       -1     
==========================================
- Hits        18511    18510       -1     
  Misses       1495     1495              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@Tobychev Tobychev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing a changelog, and I don't feel able to review the dark magic in setup.cfg, otherwise it looks fine

src/ctapipe/core/support.py Outdated Show resolved Hide resolved
@maxnoe
Copy link
Member Author

maxnoe commented Jan 8, 2024

Missing a changelog, and I don't feel able to review the dark magic in setup.cfg, otherwise it looks fine

See setuptools documentation: https://setuptools.pypa.io/en/latest/userguide/package_discovery.html#package-discovery-and-namespace-packages

@maxnoe maxnoe force-pushed the src_layout branch 7 times, most recently from 4b0f5a7 to 4ff34d7 Compare January 9, 2024 16:59
@maxnoe maxnoe marked this pull request as ready for review January 18, 2024 11:37
kosack
kosack previously approved these changes Jan 18, 2024
Tobychev
Tobychev previously approved these changes Jan 23, 2024
@maxnoe maxnoe merged commit 96a81e6 into main Jan 24, 2024
13 of 14 checks passed
@maxnoe maxnoe deleted the src_layout branch January 24, 2024 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants