Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Fix Headings in Docs [Closes #2472] #2474

Merged
merged 9 commits into from Nov 28, 2023

Conversation

aknierim
Copy link
Contributor

This PR closes #2472 by fixing the headings in the docs. Headings are now set according to the convention mentioned in the Sphinx docs on reStructuredText: https://www.sphinx-doc.org/en/master/usage/restructuredtext/basics.html#sections.

Additionally, occurrences of API Reference are changed to Reference/API and the capitalization of some headings is changed for consistency.

Copy link

codecov bot commented Nov 24, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (4a45dcd) 92.46% compared to head (d1bff23) 92.46%.

❗ Current head d1bff23 differs from pull request most recent head fa945a6. Consider uploading reports for the commit fa945a6 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2474   +/-   ##
=======================================
  Coverage   92.46%   92.46%           
=======================================
  Files         234      234           
  Lines       19868    19868           
=======================================
  Hits        18370    18370           
  Misses       1498     1498           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aknierim aknierim changed the title Fix Headings in Docs [Closes #2472] Docs: Fix Headings in Docs [Closes #2472] Nov 26, 2023
@Tobychev Tobychev added the documentation-only Label that will ensure code tests are skipped label Nov 27, 2023
Command line tools (`~ctapipe.tools`)
=====================================
*************************************
Command-Line Tools (`~ctapipe.tools`)
Copy link
Contributor

@Tobychev Tobychev Nov 27, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In docs/api-reference/reco/index.rst (and in other places) you capitalise hyphenated words ("Moment-based") as "Capital-lowercase" but here you write "Command-Line", that is using a "Capital-Capital" format. I think you chose what format to use and use that consistently.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, you're right. I decided to stick with "Capital-lowercase" when going through the files, but I guess I missed that one.

Change "To API docs" to "To the API docs", since
that is more consistent with the other two cards, i.e.
"To the user guide" and "To the developer guide".
@aknierim
Copy link
Contributor Author

That should fix it if I haven't overlooked any further inconsistencies.

@maxnoe maxnoe merged commit b175f69 into cta-observatory:main Nov 28, 2023
12 checks passed
@aknierim aknierim deleted the fix_headings branch November 28, 2023 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation-only Label that will ensure code tests are skipped
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Inconsistent sphinx heading levels in docs
3 participants